Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update README #1261

Merged
merged 6 commits into from
Jul 29, 2024
Merged

chore: Update README #1261

merged 6 commits into from
Jul 29, 2024

Conversation

volsa
Copy link
Member

@volsa volsa commented Jul 11, 2024

I've taken some inspiration from other popular open-source projects, moving the most important links to the beginning of the README and stripping it down a bit in the process. This should make reading the README more "pleasant". The rendered version can be found here (which to be fair looks very minimalistic). I'm not sure if we're a fan of this, but I thought I'd open a PR.

@volsa volsa marked this pull request as ready for review July 15, 2024 12:01
@volsa volsa requested review from ghaith, riederm and mhasel July 15, 2024 12:01
Copy link
Collaborator

@ghaith ghaith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!
Small and to the point.
I would still enable the status stuff however..
Also we should find a good contributing guide to add and link to.

README.md Outdated
Generating LLVM IR is accomplished with the help of [_inkwell_](https://github.com/TheDan64/inkwell), a Rust-wrapper around the native LLVM C-API.
Generating LLVM IR is accomplished with the help of [_inkwell_](https://github.com/TheDan64/inkwell), a Rust-wrapper around the native LLVM C-API. -->

<!-- This seems to be broken?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tokei breaks often, but it also works enough times..
Why are the other ones disabled?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for the tokei and codecov badge they felt redundant since the last commit on the master branch already provides GitHub actions information. Do you want me to re-enable them?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it would be a quick way to get to the latest build so that you can download it.. but we should probably do this differently. Maybe integrate them in the text somewhere

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@volsa volsa merged commit 50dc477 into master Jul 29, 2024
19 checks passed
@volsa volsa deleted the volsa/readme branch July 29, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants